Replace plain <a> tags with Next.js <Link> components #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
approved these changes
Oct 25, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
👍 with the one comment
| icon?: string | ReactElement | ||
| description?: string | ||
| href: string | ||
| onClick?: () => void |
Contributor
There was a problem hiding this comment.
This doesn't seem to be used? Let's remove it to avoid expanding the interface.
Contributor
Author
There was a problem hiding this comment.
It's newly used (L191) to pass the drawer close when the link is clicked.
This was referenced Oct 25, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5853.
Description (What does it do?)
Replaces any remaining plain links to internal routes with Next.js
<Link>components.How can this be tested?
Check the nav drawer links. These should navigate without reloading the page.
The header search icon should navigate without reload.
Footer links should navigate without reload ("Accessibility" and "Contact Us" are external, but still navigate ok).
Additional Context
The Channel detail links to external sites and login links in the header, user menu and Personalize section are the only remaining plain
<a>tags. The login links use<ButtonLink>withrawAnchor={true}, which we perhaps don't need as Next.js<Link>works fine for external URLs andtarget="_blank"(e.g. the MIT logo link in the header).