Shanbady/similar resources endpoint #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
added
Needs Review
abeglova
approved these changes
Oct 25, 2024
Contributor
abeglova
left a comment
abeglova
left a comment
There was a problem hiding this comment.
LGTM - one minor fix required
learning_resources_search/api.py
Outdated
| indexes = relevant_indexes([COURSE_TYPE], [], endpoint=LEARNING_RESOURCE) | ||
| search = Search(index=",".join(indexes)) | ||
| if num_resources: | ||
| search = search.extra(size=num_resources) |
Contributor
There was a problem hiding this comment.
This should be num_resources+1 since the original resource is included in the results and later filtered out. Currently you get limit-1 resources in the response
This was referenced Oct 25, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4310
Description (What does it do?)
This PR introduces a "similar resources" endpoint which is expanded onto the learning resource detail endpoint. To get similar resources for a learning resource, add '/similar' to the learning resources detail endpoint. example
How can this be tested?