Skip to content

restore images in subscription emails #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2024
Merged

restore images in subscription emails #1747

merged 2 commits into from
Oct 25, 2024

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Oct 24, 2024

Description (What does it do?)

This PR:

  • restores an image file that was statically referenced in subscription emails
  • Adds a default fallback image for resources in the email that dont have images

How can this be tested?

  • Follow instructions on this PR to send yourself a subscription email (email must be opened on the same machine your server is running on to see images render)

@shanbady shanbady marked this pull request as ready for review October 24, 2024 20:00
@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Oct 24, 2024
@abeglova abeglova self-assigned this Oct 25, 2024
abeglova
abeglova approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanbady shanbady merged commit e27f1f2 into main Oct 25, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/restore-images-in-emails branch October 25, 2024 16:04
This was referenced Oct 25, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abeglova abeglova abeglova approved these changes

Assignees

@abeglova abeglova

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shanbady @abeglova