fix list duplication when editing lists #1749
Conversation
| ) | ||
|
|
||
| # Add new items as necessary | ||
| if learning_path_id not in list(current_parent_lists): |
There was a problem hiding this comment.
I spend a while trying to debug why my conditional was not working, and it ended up being because (originally) learning_path_id was a string, whereas current_parent_lists was a list of integers.
That motivated me to make the two new serializers for validating request data.
ChristopherChudzicki
force-pushed
the
cc/list-duplicates
branch
from
2fa2a07 to
20a6ddf
Compare
ChristopherChudzicki
force-pushed
the
cc/list-duplicates
branch
from
20a6ddf to
03370f1
Compare
mbertrand
left a comment
mbertrand
left a comment
There was a problem hiding this comment.
Works great, just add some missing docstrings to the tests, and, only if you feel like it, make the suggested change to reduce code duplication.
learning_resources/serializers.py
Outdated
| ) | ||
| learning_resource_id = serializers.IntegerField() | ||
|
|
||
| def validate_learning_resource_id(self, learning_resource_id): |
There was a problem hiding this comment.
Not a big deal, but to avoid some code duplication, you could have a BaseListItemsRequestsSerializer with the validate_learrning_resource_id function defined, then have SetUserRequestSerializer and SetLearningPathRequestSerializer inherit from that.
| ) | ||
|
|
||
|
|
||
| def test_set_learning_path_request_serializer(): |
| assert "learning_resource_id" in invalid.errors | ||
|
|
||
|
|
||
| def test_set_userlist_request_serializer(): |
| ) | ||
|
|
||
|
|
||
| def test_adding_to_userlist_not_effect_existing_membership(client, user): |
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/5858
Description (What does it do?)
When assigning resources to lists (learning paths, userlists), the resource was being added again to lists it was already in. This fixes that.
How can this be tested?
main, L1 now has two copies of the resource