Skip to content

Conversation

@rhysyngsun
Copy link
Contributor

What are the relevant tickets?

Part of https://github.com/mitodl/hq/issues/5559

Description (What does it do?)

This configures the ol-oidc social auth to additionally request the ol-profile scope because it wasn't trivial to extend the profile scope w/ Pulumi. This scope is being added in mitodl/ol-infrastructure#2757.

How can this be tested?

  • In keycloak, add a ol-profile client scope.
  • Try to login and verify keycloak errors because the scope isn't valid for the client.
  • Go to the client for the Learn app and add the ol-profile scope as a default scope (it doesn't really matter default or optional since Learn requests specific ones).
  • Verify you can now login without errors.

@rhysyngsun rhysyngsun added the Needs Review An open Pull Request that is ready for review label Oct 28, 2024
@rhysyngsun rhysyngsun merged commit 8d03302 into main Oct 28, 2024
11 checks passed
@rhysyngsun rhysyngsun deleted the nl/add-ol-profile-scope branch October 28, 2024 19:16
This was referenced Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants