Skip to content

Conversation

@jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Nov 5, 2024

What are the relevant tickets?

N/A

Description (What does it do?)

Fixes an issue where we try to load YouTube videos over HTTP in a page loaded over TLS causing the video not to display and error e.g.

Mixed Content: The page at 'https://rc.learn.mit.edu/?resource=17315' was loaded over HTTPS, 
but requested an insecure frame 'http://www.youtube.com/embed/BYM_Bko4Tnc'. 
This request has been blocked; the content must be served over HTTPS.

How can this be tested?

On RC, videos should display correctly in the learning resource drawer (it's impractical to serve on HTTPS locally - we have yarn dev --experimental-https but would also need backend to do same):

image

Additional Context

@jonkafton jonkafton changed the title HTTPS youtube URLs HTTPS for YouTube iframe src Nov 5, 2024
@jonkafton jonkafton merged commit 72be4c4 into main Nov 5, 2024
11 checks passed
@jonkafton jonkafton deleted the jk/fix-http-iframe branch November 5, 2024 21:07
@jonkafton jonkafton mentioned this pull request Nov 5, 2024
14 tasks
@odlbot odlbot mentioned this pull request Nov 5, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants