SCIM /Bulk API #1985
Merged
SCIM /Bulk API #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
3 times, most recently
from
887794d to
333d675
Compare
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
3 times, most recently
from
8dbefe1 to
701de48
Compare
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
from
67bbf17 to
eba00f9
Compare
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
3 times, most recently
from
efda53d to
966cfdf
Compare
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
from
286b8a6 to
e9dcc9a
Compare
rhysyngsun
force-pushed
the
nl/scim-bulk-endpoint
branch
from
e9dcc9a to
b3a8f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6561
Description (What does it do?)
This adds functionality to expose a
/Bulkendpoint per the SCIM specification. This is implemented by internally using Django's url dispatcher to determine which view will get called for a given batch operation, calling that view, and then generating an appropriate result given the response.Additionally, I had to patch the upstream
scim_filter_parsertranspiler implementation because the way they implemented variable substitution it maxed out at 26 variables (which mean a max of 26 filters), so when the SCIM plugin was calling the search endpoint trying to find more than 26 users by email it was throwing an error. I fixed this by converting the index to a base26 string. You can see the upstream implementation here. I'll probably look into upstreaming this but this work has taken long enough to just get to the point of being reviewable I don't want to be blocked on that.How can this be tested?
Follow the setup instructions in scim/README.md. The synchronization should succeed without error.