Remove imports for builtin django User model #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysyngsun
force-pushed
the
nl/fix_user_model_refs
branch
from
ff987f5 to
011c959
Compare
rhysyngsun
force-pushed
the
nl/fix_user_model_refs
branch
from
011c959 to
6a35cb4
Compare
shanbady
requested changes
Feb 5, 2025
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
worked in catching the User import. had a question about the if TYPE_CHECKING: condition
|
|
||
| if TYPE_CHECKING: | ||
| from django.contrib.auth import get_user_model | ||
|
|
Contributor
There was a problem hiding this comment.
what does this code do? It doesnt seem like User is referenced anywhere in this file. Might be worth leaving a comment
Contributor
Author
There was a problem hiding this comment.
It's referenced in the types of some of the function arguments: https://github.com/mitodl/mit-learn/pull/2012/files/6a35cb4f70d5a4364f2eb25905f46b76d27b788a#diff-3e244d0725c2dbf2dfd444546f36377feb3dcb0bfee9838f50a971237def1e72R336
shanbady
added
Waiting on author
and removed
Needs Review
Merged
rhysyngsun
force-pushed
the
nl/fix_user_model_refs
branch
from
6a35cb4 to
1357f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/6679
Description (What does it do?)
django.contrib.auth.models.Userget_user_model()orsettings.AUTH_USER_MODELHow can this be tested?
You should be able to run the app without issue.
You can also test the lint rule by adding an import to
django.contrib.auth.models.Userin any file and runpre-commit runand it should error.You can observe that the initial commit for this PR that added this check failed for all of the existing usages: https://results.pre-commit.ci/run/github/672068771/1738783559.KuMD_PjETSqF69WSAV5Ufg