-
Notifications
You must be signed in to change notification settings - Fork 3
Initial Tiptap Editor #2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Tiptap Editor #2691
Conversation
for more information, see https://pre-commit.ci
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me locally in dev mode, but as on CI, the build is failing.
While I like the idea of minimizing the changes to the template, the alias imports may be more effort than they are worth... modifying the tsconfig and webpack config (and NextJS 16 very much wants you to use turbopack, so we'd probably want to change it soon.)
Claude wrote me this script to convert the absolute imports to relative. Seems to work pretty well: https://gist.github.com/ChristopherChudzicki/4b67b87e6eeb9789060821a79865b9d1 we could commit that script, and if need to run it again on a template update, no problem.
Regarding ol-components: I think putting TiptapEditor in its own workspace would make sense (rather than ol-components). Lots of deps there and isolate the linting exceptions.
merging with main branch
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Agree - in the end it does not seem possible to support conflicting aliases in a nested tsconfig without changing project config and adding not-so-nice workarounds. I've updated the ejected tiptap code to use relative imports. |
What are the relevant tickets?
N/A
Description (What does it do?)
Adds a basic Tiptap editor component. See #2665 for POC/background.
@/components,@/hooksand@/lib, which conflict with our main workspace existing. Some attempts were made to configure our TS and build config to avoid modifying vendor code, though fixes were not trivial - files are updated with relative imports and fixes applies for ESLint, Prettier and type checking.Screenshots (if appropriate):
How can this be tested?
Navigate to /article/new
Additional Context