Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Nov 14, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/9102

Description (What does it do?)

This Pr includes a small change so that we can properly pull boostrapped feature flags from environment variables. our existing feature-flags use hyphens which wont work for environment variables.

There is an associated ol-infrastructure PR to set the defaults based off of the spreadsheet

How can this be tested?

  1. checkout this branch
  2. Make sure you have posthog setup and enabled locally
  3. go to the homepage and note that there is no "asktim" under the search bar (assuming you dont have the feature flag set in your personal/test account)
  4. set NEXT_PUBLIC_FEATURE_home_page_recommendation_bot=True in your frontend.env file
  5. docker docker compose down web watch and docker compose up -d
  6. visit the homepage - nothing should be different ("asktim" should still be hidden)
  7. turn off your wifi and reload the homepage - note that "asktim" is visible since it falls back to the bootstrapped value (the default we want from the spreadsheet)

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Nov 14, 2025
@shanbady shanbady marked this pull request as ready for review November 14, 2025 19:48
@mbertrand mbertrand self-assigned this Nov 17, 2025
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Nov 17, 2025
@shanbady shanbady merged commit db3f91f into main Nov 17, 2025
13 checks passed
@shanbady shanbady deleted the shanbady/posthog-feature-flag-defaults branch November 17, 2025 18:29
@odlbot odlbot mentioned this pull request Nov 17, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants