Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Nov 17, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/9290

note: the openapi diff error appears to be unrelated to these changes

Description (What does it do?)

This PR re-introduces a missing celery task decorator to the sync_topics task

How can this be tested?

  1. checkout main
  2. attempt to run python manage.py sync_topic_embeddings
  3. see that it fails with an error
  4. checkout this branch
  5. restart celery and re-run the command - note that it passes

@github-actions
Copy link

OpenAPI Changes

Show/hide 7 changes: 7 error, 0 warning, 0 info
7 changes: 7 error, 0 warning, 0 info
error	[request-parameter-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources_search/
		removed the enum value 'hybrid' from the 'query' request parameter 'search_mode'

error	[request-parameter-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources_user_subscription/
		removed the enum value 'hybrid' from the 'query' request parameter 'search_mode'

error	[request-parameter-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API GET /api/v1/learning_resources_user_subscription/check/
		removed the enum value 'hybrid' from the 'query' request parameter 'search_mode'

error	[request-parameter-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API POST /api/v1/learning_resources_user_subscription/subscribe/
		removed the enum value 'hybrid' from the 'query' request parameter 'search_mode'

error	[request-property-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API POST /api/v1/learning_resources_user_subscription/subscribe/
		removed the enum value 'hybrid' of the request property 'search_mode/allOf[#/components/schemas/SearchModeEnum]/'

error	[request-property-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API POST /api/v1/learning_resources_user_subscription/subscribe/
		removed the enum value 'hybrid' of the request property 'search_mode/allOf[#/components/schemas/SearchModeEnum]/'

error	[request-property-enum-value-removed] at head/openapi/specs/v1.yaml	
	in API POST /api/v1/learning_resources_user_subscription/subscribe/
		removed the enum value 'hybrid' of the request property 'search_mode/allOf[#/components/schemas/SearchModeEnum]/'


Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Nov 17, 2025
@shanbady shanbady marked this pull request as ready for review November 17, 2025 20:57
@mbertrand mbertrand self-assigned this Nov 18, 2025
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Nov 18, 2025
@shanbady shanbady merged commit 2821e76 into main Nov 18, 2025
12 of 13 checks passed
@shanbady shanbady deleted the shanbady/sync-topics-bug branch November 18, 2025 15:49
@odlbot odlbot mentioned this pull request Nov 24, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants