Flaky test vector_search/tasks_test.py::test_embeddings_healthcheck_missing_both #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
changed the title
shanbady
changed the title
shanbady
deleted the
shanbady/flaky-test_embeddings_healthcheck_missing_both
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/9340
Description (What does it do?)
This PR fixes a flaky test that fails due to unexpected runs created within the factory.
This PR also includes a change to add pytest-repeat which allows us to run tests x amount of times via
pytest --count nHow can this be tested?
poetry add pytest-repeatpytest --count 100 vector_search/tasks_test.py::test_embeddings_healthcheck_missing_both --pdb -x -sand see it fail