Asciimath nowrap overscripts #170
Conversation
ChristopherChudzicki
force-pushed
the
asciimath-nowrap-overscripts
branch
from
03a598e to
82a9882
Compare
|
I forgot to update my local repo. Updated, rebased, and force-pushed. I deleted the old fix from #164 |
jolyonb
left a comment
jolyonb
left a comment
There was a problem hiding this comment.
Looks good to me, assuming that your javascript syntax is correct ;-) Just the one comment.
| var middle = '{:' + eqn.slice(funcStart, funcEnd) + ':}' | ||
| eqn = front + middle + eqn.slice(funcEnd) | ||
| var middle = eqn.slice(funcStart, funcEnd) | ||
| eqn = front + wrapIfNotOverscript(null, middle) + eqn.slice(funcEnd) |
There was a problem hiding this comment.
I think this is unnecessary, as nothing in the set contains parentheses, and this is only called for completed functions, right?
There was a problem hiding this comment.
wrapFuncCalls wraps incomplete function calls:
wrapFuncCalls('cat(') // returns '{:cat:}(
wrapVariables('cat(') // returns 'cat('Now, I'm not sure that wrapping incomplete function calls is actually necessary... I think when we encountered the issues with x'/2 and p(x)/2, we adopted "wrap everything" as a philosophy, so I wrapped incomplete function calls, too. (Overscript issues has made me question that philosophy...)
There was a problem hiding this comment.
Ah, the point was more that the old code is equivalent to the new code, unless I'm missing something?
There was a problem hiding this comment.
I think that the test I added for wrapFuncCalls describes how we want it to behave for overscript symbols:
The middle two cases for that test require this alteration to wrapFuncCalls.
There was a problem hiding this comment.
Ah, I see now. Very good! Thanks for the clarifications. For posterity, I'll add that overline() converts to {:overline():}, which is the desired behavior, and works in AsciiMath.
2 participants
Resolves #169