Py23 more #215
Merged
Py23 more #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also re-worked the Python 2 version so that it should now work for Python 3. But the Python-3 only version is much simpler. Also, the Python 2 version raises deprecation warnings in Python 3 (for getargspec).
Collaborator
|
Excellent. I'll trade you a review of this for #214 ;-) |
zip, map, filter, .keys(), .items(), and .values() return single-use iterators in Python 3, but lists in Python 2. I've changed all instances of these iterators to explicit lists unless the instance is immediately consumed (i.e., not given a reference for reuse).
jolyonb
reviewed
Jul 2, 2019
Collaborator
|
This is getting to be a chunky PR - almost at 700 lines here. I figure there's more you want to do, but is this reviewable as is? (I'd prefer not to do a 1000 line PR...) |
Even though this is consumed immediately in a for-loop, it needs to be a list not a generator since its dictionary is being modified.
When used on class constructors:
```python
class Foo(object):
def __call__(self, x):
return x
```
get_number_of_args_py2 previously returned the number of arguments in Foo.__call__, which was incorrect, since calling Foo(...) would run the __init__ method!
Collaborator
Author
|
Sure, this is ready for review. Most of the +500 –300 lines are reasonably trivial changes to the doctests. |
Collaborator
Author
|
BTW: Only 8 Python 3 tests are failing. I'll tackle them tomorrow. |
jolyonb
reviewed
Jul 2, 2019
Collaborator
|
Alrighty, will tackle this first thing tomorrow morning! |
jolyonb
reviewed
Jul 2, 2019
jolyonb
reviewed
Jul 2, 2019
jolyonb
reviewed
Jul 2, 2019
jolyonb
requested changes
Jul 2, 2019
Collaborator
jolyonb
left a comment
jolyonb
left a comment
There was a problem hiding this comment.
All looks good to me. Very minor changes requested.
jolyonb
approved these changes
Jul 2, 2019
Collaborator
jolyonb
left a comment
jolyonb
left a comment
There was a problem hiding this comment.
LGTM 👍. Will merge when tests complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.