This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Removing lxml dependency #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2014 10:42
|
Changes Unknown when pulling 380b245 on feature/no_lxml into * on develop*. |
Contributor
There was a problem hiding this comment.
So I take it that the functionality that you were getting from lxml, you can also get from xml.etree, thereby eliminate the need to require the lxml library?
Contributor
Author
There was a problem hiding this comment.
That is correct. I needed to add XML declaration below, but it produces same functionality. And without need for libxml.
Libxml is native XML library and if we are doing a lot of XML processing it would be worth while, but we can get
added 2 commits
October 29, 2014 15:39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4