Remove extensible schemas and update documentation #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seansica
approved these changes
Aug 7, 2025
Contributor
seansica
left a comment
seansica
left a comment
There was a problem hiding this comment.
LGTM!
All tests pass. Also confirmed Docusaurus builds (w/o the extensibles!)
- Fix code references to DataSourceRegistration - Reformat section about the Docusaurus site
The strict schema validation was rejecting the 'objects' key when using .pick to validate only bundle 'id' and 'type' keys, causing AttackDataModel instances with zero objects loaded. Added .loose() to allow the 'objects' key to pass through validation. Fixes issue where registerDataSource() would return empty data models despite successful data fetching from ATT&CK GitHub repo.
…el into doc-cleanup
…el into doc-cleanup
…el into doc-cleanup
seansica
approved these changes
Sep 12, 2025
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.