Skip to content

fix flaky CI tests #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix flaky CI tests #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions MixpanelDemo/MixpanelDemoTests/MixpanelDemoTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,25 +969,28 @@ class MixpanelDemoTests: MixpanelBaseTests {

func testMultipleInstancesWithSameTokenButDifferentInstanceName() {
let testToken = randomId()
let instance1 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: "instance1")
let instance2 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: "instance2")
let instanceName1 = randomId()
let instanceName2 = randomId()
let instance1 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: instanceName1)
let instance2 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: instanceName2)

XCTAssertNotEqual(instance1.distinctId, instance2.distinctId)
instance1.identify(distinctId: "user1")
instance1.track(event: "test")
waitForTrackingQueue(instance1)
waitForTrackingQueue(instance2)

XCTAssertEqual(instance1.distinctId, "user1")
XCTAssertEqual(instance1.userId, "user1")
let events = eventQueue(token: "instance1")
let events = eventQueue(token: instanceName1)
let properties = events.last?["properties"] as? InternalProperties
// TODO: Need to figure out why this test is flaky
// event property should have the current distinct id
//XCTAssertEqual(properties?["distinct_id"] as? String, "user1")
XCTAssertEqual(properties?["distinct_id"] as? String, "user1")

instance1.people.set(property: "p1", to: "a")
waitForTrackingQueue(instance1)

let peopleQueue_value = peopleQueue(token: "instance1")
waitForTrackingQueue(instance2)

let peopleQueue_value = peopleQueue(token: instanceName1)
let setValue = peopleQueue_value.last!["$set"] as! InternalProperties
XCTAssertEqual(setValue["p1"] as? String, "a", "custom people property not queued")

Expand All @@ -996,26 +999,28 @@ class MixpanelDemoTests: MixpanelBaseTests {

instance2.identify(distinctId: "user2")
instance2.track(event: "test2")
waitForTrackingQueue(instance1)
waitForTrackingQueue(instance2)
XCTAssertEqual(instance2.distinctId, "user2")
XCTAssertEqual(instance2.userId, "user2")
let events2 = eventQueue(token: "instance2")
let events2 = eventQueue(token: instanceName2)
let properties2 = events2.last?["properties"] as? InternalProperties
// event property should have the current distinct id
XCTAssertEqual(properties2?["distinct_id"] as? String, "user2")

instance2.people.set(property: "p2", to: "b")
waitForTrackingQueue(instance1)
waitForTrackingQueue(instance2)

let peopleQueue2_value = peopleQueue(token: "instance2")
let peopleQueue2_value = peopleQueue(token: instanceName2)
XCTAssertEqual(peopleQueue2_value.last?["$distinct_id"] as? String,
"user2", "distinct id not set properly on the people record")

let setValue2 = peopleQueue2_value.last!["$set"] as! InternalProperties
XCTAssertEqual(setValue2["p2"] as? String, "b", "custom people property not queued")

removeDBfile("instance1")
removeDBfile("instance2")
removeDBfile(instanceName1)
removeDBfile(instanceName2)
}

func testReadWriteMultiThreadShouldNotCrash() {
Expand Down