FIX: featureFlags.set() does not update cached featureFlags #42

[dejewi]

No description provided.

[coveralls]

Coverage remained the same at 100.0% when pulling 4c5b52d on dejewi:master into 99f20e6 on mjt01:master.

[michaeltaranto]

Thanks for putting this together, are you able to provide a test that fails to capture your fix? Also if you can remove the version bump and dist changes from your PR that will come through with the publishing.

[coveralls]

Coverage remained the same at 100.0% when pulling 8d4602e on dejewi:master into 99f20e6 on mjt01:master.

[dejewi]

Sure :)
I reverted bump version and dist changes. I also provided test.

[dejewi]

Hi Michael, Did you had chance to review my last update?

[michaeltaranto]

Looks good to me, thanks for making those changes.

[michaeltaranto]

@dejewi I have reverted this PR in v1.6.0 based on https://github.com/mjt01/angular-feature-flags/issues/44. Having reviewed the issues raised I agree that the correct behaviour is not what was set last, rather that the local override wins. Sorry for the confusion, I'm not actively working on this module so it can be hard to build enough context to review intent thoroughly enough.

[dejewi]

ohh :(
How about if I will introduce additional parameter to control overriding eg. by default featureFlags.set() will not override feature flags stored in localstorage but if we will set/or pass additional boolean parameter set on true then we will override feature flags?

[michaeltaranto]

On reflection I actually think you are using the model incorrectly (hence the roll back). The enable function is about setting a local override for what is otherwise the source of truth. The idea of setting a local override then overriding the override using set does not sound right.

You're probably after a resetAll that deletes all overrides right?

[dejewi]

Generally I don't use resetAll. My use case is very simple:

1. in config phase set default feature flags required to run application (or just in case if feature flag service is not available), eg flag ARE_FEATURE_FLAGS_LOADED

myApp.config(function(featureFlagsProvider) {
  featureFlagsProvider.setInitialFlags([
    { "key": "ARE_FEATURE_FLAGS_LOADED", "active": false, "name": "...", "description": "..." },
  ]);
});

2. in run phase set whole the most up-to-date feature flag list (with eg. ARE_FEATURE_FLAGS_LOADED feature flag set on true)

myApp.run(function(featureFlags, $http) {
  featureFlags.set($http.get('/api/flags'));
});

And after this two steps ARE_FEATURE_FLAGS_LOADED is set on false instead of true