Drop kleur dependency in favor of node:util's styleText
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkantor
commented
Aug 5, 2025
Comment on lines
+29
to
+32
| // Warning: the global state mutation here means that we can't style text in static contexts! | ||
| // Functions like `node:util`'s `styleText` shouldn't be called from the top level of modules. | ||
| delete process.env['FORCE_COLOR'] | ||
| process.env['NO_COLOR'] = 'true' |
Owner
Author
There was a problem hiding this comment.
This feels even worse than the global state mutation I had to do for kleur, but on the upside it's more general: now --no-color will also disable styling in stack traces, console.log output, etc.
mkantor
changed the title
kleur dependency in favor of [node:util's styleText](https://nodejs.org/api/util.html#utilstyletextformat-text-options)kleur dependency in favor of node:util's styleText
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was satisfying to eliminate the only non-dev third-party dependency.