Conversation
oprypin
force-pushed
the
rename
branch
8 times, most recently
from
8ba5884 to
61a380a
Compare
oprypin
changed the title
oprypin
changed the title
Some references, such as references to old versions of MkDocs, are still left. docs/about/release-notes.md is not processed at all yet. This is because the historic info probably should still say the previous name. Maybe *some* of it should be changed, but that can be left until later.
Note that some replacements are intentionally skipped - primarily the theme's name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost every instance is replaced:
"MkDocs" -> "ProperDocs"
"mkdocs" -> "properdocs"
This is a simple mass-replacement, no other changes are made. (Deletion of
www.is the only other change, I think)Some references, such as references to old versions of MkDocs, are still left alone intentionally. (release-notes.md is not processed)
The theme's name is also left alone.
I think this would really benefit from additional review. Most important is to notice places that should not have been renamed, for the above reasons or some other reason.
When reviewing the changes, consider looking at them commit-by-commit, it's probably easier to spot things that way.