Fix CLI livereload option and CI failures in tests#4
Merged
shenxianpeng merged 5 commits intomasterfrom Apr 22, 2026
Merged
Conversation
- toc.py: simplify 'if len(toc):' to 'if toc:' (PLC1802) - tests/base.py: use dict.fromkeys() instead of dict comprehension (C420) - config_options.py: reformat PathSpec.run_validation() to fit line length (black)
PyPy 3.9 on Windows fails to install hatch because hatch's zstandard dependency requires CFFI compilation which needs distutils.msvc9compiler, a module removed in newer Python versions and unavailable on PyPy 3.9 for Windows.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MkDocs’ CLI and CI/build configuration to improve developer experience and expand interpreter coverage, with a few small internal cleanups.
Changes:
- Simplifies the
mkdocs servelivereload flags into a single Click boolean flag pair. - Expands Hatch and GitHub Actions CI matrices to include newer CPython versions and adjusts packaging checks.
- Minor refactors/cleanup (dict construction, truthiness check, dedenting multiline pathspec config).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Adds explicit wheel package configuration and expands Hatch test/integration Python matrices. |
mkdocs/tests/base.py |
Refactors tempdir helper dict creation. |
mkdocs/structure/toc.py |
Simplifies non-empty TOC check. |
mkdocs/config/config_options.py |
Dedents multiline PathSpec strings before parsing. |
mkdocs/__main__.py |
Reworks serve livereload options into --livereload/--no-livereload. |
.github/workflows/ci.yml |
Expands CI Python versions, excludes PyPy+Windows, and updates package artifact name patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
shenxianpeng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.