Merged
Conversation
Contributor
|
This needs a note added to the release notes as well as a test which fails before the change is made and passes after. |
lukasgeiter
force-pushed
the
fix/get-by-type
branch
from
8702ad2 to
4c582bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
_get_by_typefunction doesn't work properly when used to find nestedSectionitems. Since theifcondition is true, it would not actually traverse the children of sections.This is currently not causing any problems because MkDocs only uses the function with
PageandLink. But I thought it would be a good idea to fix it anyway, in case that changes in the future.