URL are changed in <script src> from code blocks

[Toilal]

I face a really strange issue.

Please see this file, and notice in Install Manually section, step 4, in the sample code.

<script src="assets/angular-gantt.js"></script>

When i generate the docs using mkdocs build, it gives the following page, and the script source is changed :

<script src="../assets/angular-gantt.js"></script>

Notice the ../ added to the begining of file. This may have sense for real <script src...> tag, but it should not occur inside a code block (4-space indent or quoted)

Page generated by readthedocs has the same issue.

[d0ugal]

ah, I know why that is happening. I think it is being detected as an image, so we re-write the path as if the images are in the root.

[d0ugal]

So, this happens, because we need to correct the path to images as the "location" changes from a file getting-started.md to a directory getting-started/ so the reference needs to be moved. However, we should not touch anything inside a code block. So, essentially, these regular expressions are far too naive: https://github.com/tomchristie/mkdocs/blob/master/mkdocs/build.py#L79-L87

We peobably need to change to a tool that understand HTML structure. Using regexes for this is a bad idea.

[Toilal]

I've commented your commit for a better regexp. But for sure, it should not be regexp here, as code blocks should be totally exluded.

[d0ugal]

Yeah, I just hacked that together to check it fixed the problem I'll try and figure out a more robust solution.

[d0ugal]

Fixing something like this would be really easy with pyquery but it is quite a heavyweight dependency. Thoughts @tomchristie ?

[lovelydinosaur]

Lukewarm in that, at least right now.

I'd have thought than a markdown extension (ie we have some parsing info available to us) might be another option maybe?

[d0ugal]

Hmm, true. If nothing else, processing the markdown would be easier than the HTML. I'll look into an extension.

[SvenDowideit]

yes, iirc, I made some change to this in the docker version - as relative URL's are mostly not useful in our context.