Build issue

[nateskulic]

Hi!

I wanted to try to build this (in the form of an rpm package).

It stops during a cmake build, right after the pcre2 target.

I think it might have to do with pybind11... I tried using the system provided pybind11, but it couldn't find that for some reason (maybe that is best as a separate issue).

Keep getting an error I can't seem to get any debug on, or get past.

Tried the latest release (4.7.1) and the latest checkout (as of 20250121).

Wondering if you have any clues.

The error follows:

[ 45%] Completed 'pcre2'
/usr/bin/cmake -E make_directory $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/CMakeFiles
/usr/bin/cmake -E touch $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/CMakeFiles/pcre2-complete
/usr/bin/cmake -E touch $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/pcre2-prefix/src/pcre2-stamp/pcre2-done
gmake[2]: Leaving directory '$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build'
[ 45%] Built target pcre2
gmake[1]: Leaving directory '$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build'
gmake: *** [Makefile:139: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.HxXc7c (%build)

($HOME is my home)

Using the following to setup cmake:

/usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=Release -DWITH_X11_FEATURES=OFF -DWITH_DESKTOP=ON -DBUILD_TAGLIB=OFF -DBUILD_RUBBERBAND=OFF -DBUILD_PYBIND11=ON -DBUILD_XZ=ON -DBUILD_OPENBLAS=OFF -DBUILD_FMT=OFF -DBUILD_LIBARCHIVE=OFF -DWITH_PY=ON -DBUILD_QQC2_BREEZE_STYLE=ON -DBUILD_VOSK=OFF -DBUILD_CATCH2=OFF -DBUILD_WHISPERCPP_VULKAN=ON -DBUILD_FFMPEG=ON -DBUILD_BERGAMOT=OFF -DBUILD_RHVOICE=OFF -DBUILD_RHVOICE_MODULE=OFF -DDOWNLOAD_LIBSTT=OFF -DBUILD_ESPEAK_MODULE=OFF -DBUILD_WHISPERCPP_CUBLAS=OFF -DBUILD_WHISPERCPP_HIPBLAS=OFF

[mkiol]

Nice!

The cmake command looks fine. I checked it on my system and it works. Most likely, the problem lies in a missing dependency that was not checked at the configuration stage (aka cmake stage). The root cause is printed somewhere above the lines you pasted. It is definitely not a problem with pcre2.

Can you try also with -DBUILD_QQC2_BREEZE_STYLE=OFF?

[nateskulic]

Just attempted with -DBUILD_QQC2_BREEZE_STYLE=off; same stop point and error.

You are probably right in regards to missing dependency. I've been attempting to match up requirements with the arch PKGBUILD, but probably missed something. This is a build machine, so excessive amount of dependencies and devel packages are already installed.

Also tried export VERBOSE=1 and export V=1 to see if make/gmake would pick up something.

I'm not sure which Makefile the line number is coming from (dammit, make). If it was the one at the root of build, annotated below:

# The main all target
all: cmake_check_build_system
        $(CMAKE_COMMAND) -E cmake_progress_start $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/CMakeFiles $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build//CMakeFiles/progress.marks
        $(MAKE) $(MAKESILENT) -f CMakeFiles/Makefile2 all # <<< failing line (139)
        $(CMAKE_COMMAND) -E cmake_progress_start $HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/CMakeFiles 0

[mkiol]

I've been attempting to match up requirements with the arch PKGBUILD, but probably missed something.

Rather, it is a problem in the cmake script. All dependencies should be verified during the "cmake" step, but not in "make", so it's a bug on my side.

Can you share entire output from cmake and make run?

[nateskulic]

Aha, yes, definitely a cmake dependency check missing.

Log attached; it's the output of rpmbuild. Any rpmbuild lines are prefixed with + . Both cmake and make are called in this log.

dsnote.log

[mkiol]

I honestly don't know what went wrong. This log of multi-threaded build is very difficult to read. Can you try with only one thread by adding -j1 to make step?

I suspect this may be the cause (but I am most likely wrong):

-- Found Vulkan: /lib64/libvulkan.so (found version "1.3.283") found components: glslangValidator missing components: glslc

What is the result with -DBUILD_WHISPERCPP_VULKAN=OFF?

[nateskulic]

Flag is now -DBUILD_WHISPERCPP_VULKAN=OFF; same error.

Tried installing glslc, as it was supposedly missing; same error.

-j1 caused an error:

checking whether we are cross compiling... configure: error: in `$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/external/rnnoise'
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details

Digging more, I flipped on -DCMAKE_BUILD_PARALLEL_LEVEL=1, also passing --parallel 1 and -j1 to cmake --build, and it slowed the build down, failing at a different [earlier] point:

[  8%] Built target whispercppopenblas
gmake[1]: Leaving directory '$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build'
gmake: *** [Makefile:139: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.9nkLuE (%build)

Setting it to -j2 to -j5 resulted in the same error, more or less. -j6 brings us to the PCRE stop point. Tried variations of these flags (including -DCMAKE_BUILD_PARALLEL_LEVEL=2) to see if it would move different or past, to no avail.

[mkiol]

Thanks for checking.

When using j1, build stops exactly when an error occurs. In parallel build, multiple targets are compiled at the same time, so entire build stops when all parallel tasks are finished. Therefore output log is messy.

So output of j1 tells us what went wrong. It seems that the problem is related to rnnoise. Can you check what is in the log file config.log?

See `config.log' for more details

[nateskulic]

This is the contents of rnnoise config.log:

Configured with: ../configure --enable-bootstrap --enable-host-pie --enable-host-bind-now --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.rockylinux.org/ --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --enable-plugin --enable-initfini-array --without-isl --enable-multilib --with-linker-hash-style=gnu --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_64=x86-64-v2 --with-arch_32=x86-64 --build=x86_64-redhat-linux --with-build-config=bootstrap-lto --enable-link-serialization=1
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.5.0 20240719 (Red Hat 11.5.0-2) (GCC)
... rest of stderr output deleted ...
configure:2610: $? = 0
configure:2599: gcc -V >&5
gcc: error: unrecognized command-line option '-V'
gcc: fatal error: no input files
compilation terminated.
configure:2610: $? = 1
configure:2599: gcc -qversion >&5
gcc: error: unrecognized command-line option '-qversion'; did you mean '--version'?
gcc: fatal error: no input files
compilation terminated.
configure:2610: $? = 1
configure:2630: checking whether the C compiler works
configure:2652: gcc -Dpitch_downsample=rnnoise_pitch_downsample     -Dpitch_search=rnnoise_pitch_search     -Dremove_doubling=rnnoise_remove_doubling     -D_celt_lpc=rnnoise__celt_lpc     -Dcelt_iir=rnnoise_celt_iir     -D_celt_autocorr=rnnoise__celt_autocorr     -Dcompute_gru=rnnoise_compute_gru     -Dcompute_dense=rnnoise_compute_dense  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  conftest.c  >&5
configure:2656: $? = 0
configure:2704: result: yes
configure:2707: checking for C compiler default output file name
configure:2709: result: a.out
configure:2715: checking for suffix of executables
configure:2722: gcc -o conftest -Dpitch_downsample=rnnoise_pitch_downsample     -Dpitch_search=rnnoise_pitch_search     -Dremove_doubling=rnnoise_remove_doubling     -D_celt_lpc=rnnoise__celt_lpc     -Dcelt_iir=rnnoise_celt_iir     -D_celt_autocorr=rnnoise__celt_autocorr     -Dcompute_gru=rnnoise_compute_gru     -Dcompute_dense=rnnoise_compute_dense  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  conftest.c  >&5
configure:2726: $? = 0
configure:2748: result:
configure:2770: checking whether we are cross compiling
configure:2778: gcc -o conftest -Dpitch_downsample=rnnoise_pitch_downsample     -Dpitch_search=rnnoise_pitch_search     -Dremove_doubling=rnnoise_remove_doubling     -D_celt_lpc=rnnoise__celt_lpc     -Dcelt_iir=rnnoise_celt_iir     -D_celt_autocorr=rnnoise__celt_autocorr     -Dcompute_gru=rnnoise_compute_gru     -Dcompute_dense=rnnoise_compute_dense  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  conftest.c  >&5
/usr/bin/ld: /tmp/ccirbkrv.o: relocation R_X86_64_32 against `.rodata' can not be used when making a PIE object; recompile with -fPIE
collect2: error: ld returned 1 exit status
configure:2782: $? = 1
configure:2789: ./conftest
$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/external/rnnoise/configure: line 2791: ./conftest: No such file or directory
configure:2793: $? = 127
configure:2800: error: in `$HOME/rpmbuild/BUILD/dsnote-20250121/redhat-linux-build/external/rnnoise':
configure:2802: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details

Looks like it's saying to add an fPIE flag, which I may do. Currently, using mostly system provided/packager recommended default flags for compilation/etc (CC/LDFLAGS/etc).

[mkiol]

I don't know what is wrong :/

I compared with the config.log generated on my system and there are differences in the linker flags.

your system:

configure:2778: gcc -o conftest -Dpitch_downsample=rnnoise_pitch_downsample     -Dpitch_search=rnnoise_pitch_search     -Dremove_doubling=rnnoise_remove_doubling     -D_celt_lpc=rnnoise__celt_lpc     -Dcelt_iir=rnnoise_celt_iir     -D_celt_autocorr=rnnoise__celt_autocorr     -Dcompute_gru=rnnoise_compute_gru     -Dcompute_dense=rnnoise_compute_dense  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  conftest.c  >&5

my:

configure:3220: gcc -o conftest -Dpitch_downsample=rnnoise_pitch_downsample     -Dpitch_search=rnnoise_pitch_search     -Dremove_doubling=rnnoise_remove_doubling     -D_celt_lpc=rnnoise__celt_lpc     -Dcelt_iir=rnnoise_celt_iir     -D_celt_autocorr=rnnoise__celt_autocorr     -Dcompute_gru=rnnoise_compute_gru     -Dcompute_dense=rnnoise_compute_dense   conftest.c  >&5

It looks like you are adding the following additional flags: -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1. I have no idea what they are for, but perhaps these flags are causing the problem.

[nateskulic]

I believe these are default hardening for redhat distributions.

/usr/lib/rpm/redhat/redhat-hardened-ld contains:

*self_spec:
+ %{!static:%{!shared:%{!r:-pie}}}

Which I believe may be adding the -pie flag if not building a shared/static library.

/usr/lib/rpm/redhat/redhat-annobin-cc1 contains:

*cc1_options:
+ %{!-fno-use-annobin:%{!iplugindir*:%:find-plugindir()} -fplugin=annobin}

-Wl,OPTION: Pass OPTION as an option to the linker. If OPTION contains commas, it is split into multiple options at the commas.

• -z,now may be "BIND_NOW", resolving all symbols before execution.
• -z,relro is "Hardening ELF binaries using Relocation Read-Only (RELRO)" (makes the dynamic relocation offset table read-only after initial relocation) See redhat and blog
• --as-needed is "don't link against/with unused libraries provided"

I think rnnoise's configure is not picking up the intended flags for some reason; maybe something autotools related.
I'll see what i can do to dig out the failing conftest.c, because it's not showing me it, and I can't find it.

[nateskulic]

Also, being no fan of autotools, I would suggest integrating as much as possible with the cmake build system of this project.

For example, for rnnoise, see this CMakeLists.txt

While I can imagine it can't be done for every dependency, I can see it being reasonable for small libraries — reducing the dependency on autotools insanity.

[mkiol]

For example, for rnnoise, see this CMakeLists.txt
While I can imagine it can't be done for every dependency, I can see it being reasonable for small libraries — reducing the dependency on autotools insanity.

Sounds like something I can do. This project already has plenty of patches, so one more won't make a difference.

I think rnnoise's configure is not picking up the intended flags for some reason; maybe something autotools related.

I tried to inject all the flags from your compilation and was not able to reproduce the error. Do you know how, in a not-too-painful way, I could reproduce exactly the environment and toolchain that are used in your build?

[nateskulic]

I just tested this:

Prerequisites:

• A way to run virtual machines (e.g. virtualbox, or libvirt and virtual machine manager)

Reproduction steps:

1. Install rocky 9.5 in a VM with network access. The minimal iso is sufficient.

   • Make sure to enable the root account and ssh access during install.
   • I suggest at least 20-30gb of disk. Standard partition layout is fine.

2. Sign in as root. All steps after this are inside the virtual machine.

   • you can typically access the machine with ssh root@ip where ip is probably 192.168.122.xxx
   • you may want to copy/set up ssh keys to ssh/scp into the VM easier.

3. Install some packages to start things off by running dnf install rpmdevtools yum-utils epel-release

4. Enable the Code ready builder repository (for devel packages, among others) by running
   dnf config-manager --set-enabled crb

5. Run rpmdev-setuptree to setup the ~/rpmbuild folder.

6. Download the attached dsnote.spec.txt file to ~/rpmbuild/SPECS (make sure to remove the .txt extension).

7. Download dsnote source release tar.gz to ~/rpmbuild/SOURCES. If master release, folder in source tar must be renamed to dsnote-{version}, where {version} matches the version in the rpm spec file (e.g. dsnote-master to dsnote-YYYYMMDD). Release archives are usually named/structured correctly and don't require renaming. (For example, curl -o dsnote-4.7.1.tar.gz https://github.com/mkiol/dsnote/archive/refs/tags/v4.7.1.tar.gz)

8. Install dependencies to build dsnote by running yum-builddep ~/rpmbuild/SPECS/dsnote.spec

9. Run rpmbuild -bb ~/rpmbuild/SPECS/dsnote.spec to build rpm, subsequently reporting error.

Spec file attached. It's incomplete; missing lines for runtime "Requires" (as I haven't gotten to that point yet), and there is probably some BuildRequires packages missing.

I've currently uncommented the %cmake_build macro; it normally expands to cmake --build -j16 ....... Note: rpmbuild will complain if you leave macro markers in comments.

Hope its not too painful. 🙂

[mkiol]

This is a very cool manual :) You explained everything perfectly. I'll try it out over the weekend and let you know the results.