fixes: #14: fixed History keyboard traveling#17
Merged
mkrl merged 1 commit intomkrl:masterfrom Oct 16, 2021
Merged
Conversation
fumblehool
force-pushed
the
fix/history-keyboard-traveling
branch
from
0a8488b to
dbafc7c
Compare
mkrl
approved these changes
Oct 16, 2021
Owner
mkrl
left a comment
mkrl
left a comment
There was a problem hiding this comment.
Great job!
Looks good, tested locally
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed (if any).
Fixes #14
Pre-review checklist:
Further Discussion:
I think the better approach should be to maintain the current
indexor maintain two variables:prevHistoryIndexandnextHistoryIndex