Handle mock API #112
Handle mock API #112
Conversation
ghost
marked this pull request as ready for review
|
@mvn-binhnguyen-hn cc: @jacksonjp |
|
@mvn-binhnguyen-hn |
|
@jacksonjp @geekonthemove cc: @mvn-binhnguyen-hn @mvn-binhnguyen-hn |
| const authInterceptor = async (request: AxiosRequestConfig) => { | ||
| request.params = toSnakeCase(request.params, true); | ||
| request.data = toSnakeCase(request.data, true); | ||
|
|
There was a problem hiding this comment.
Lets leave this to the project, this totally depends on the backend implementation and debugging to find this can be difficult
| * @param {AxiosResponse} response | ||
| */ | ||
| const responseInterceptor = (response: AxiosResponse) => { | ||
| response.data = toCamel(response.data); |
There was a problem hiding this comment.
Same here, it can vary from projects
| @@ -0,0 +1,7 @@ | |||
| import MockAdapter from "axios-mock-adapter"; | |||
There was a problem hiding this comment.
As discussed, lets have it in the readme, instead of adding a package that we might not use.
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Lets move it to clients folder, so its easy to cleanup
Both above implementations seem not necessary for the admin panel template, it depends on which project the template will be used, so should we ignore and close this PR? |
|
@mvn-binhnguyen-hn Yea i think lets close this PR |
ghost
closed this
@jacksonjp Okay, I closed this PR. thanks 👍 |
3 participants
Handle mock API
What are you adding?
Clientsscreen as template screenBreaking changes?
Related PR