Fix error handling for CLI calls #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2022 09:10
…e into gergely/error-handling
szg251
force-pushed
the
gergely/error-handling
branch
from
63501a0 to
7990706
Compare
szg251
commented
Feb 11, 2022
| , networkOpt pabConf | ||
| ] | ||
| ) | ||
| ( ( \out -> |
Collaborator
Author
There was a problem hiding this comment.
I realised that the callCommand will throw an IOErr exception when fails, so parsing the output is unnecessary, it's enough to know that the exitcode is 0
samuelWilliams99
approved these changes
Feb 11, 2022
src/BotPlutusInterface/Contract.hs
Outdated
| fileWriteRes <- | ||
| Files.writeAll @w contractEnv.cePABConfig tx | ||
| eitherT (pure . WriteBalancedTxFailed . OtherError) (pure . WriteBalancedTxSuccess . Right) $ do | ||
| void $ firstEitherT (Text.pack . show) $ newEitherT $ Files.writeAll @w contractEnv.cePABConfig tx |
Contributor
There was a problem hiding this comment.
Theres a lot going on here, but I can't think of a way to simplify when using EitherT :(
mikekeke
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #45