-
Notifications
You must be signed in to change notification settings - Fork 8
Indirection layer for node #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TotallyNotChase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the indirection here. I assume it allows some abstraction to easily switch out providers. This is how Atlas and similar Haskell frameworks work as well so it's very nice.
db1e4dc to
6b4f990
Compare
aciceri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does several different unrelated things:
- bump kupo: approved 👍
- add demeter package: approved 👍
- add demeter service: seems good, if it works it's approved 👍
- indirection layers: am I understanding it wrong or it would be useful only for demeter? You can use it choosing between different providers (including
cardano-node), right? Could you please provide an example where this new layer is useful?
Also, since you changed theouramodule, it's already implicitly tested by theouratest but would it be possible to have a more specific test? - fix the docs generation: what caused this? Did you update the
nixpkgsinput? Honestly I can't understand why it was failing and why now it works but I'm happy if now works.
I don't want to slow down this so I can already merge if you think it's ready, I only ask to create issues for what we are missing if we choose to merge (different issues since they can be worked on in parallel, so PRs last less hopefully) i.e.
- implement a test for
demeter - implement
options.cardano.demeter-run.kupo(with a test) - implement
options.cardano.demeter-run.ogmios(with a test) - make
kupo,blockfrostandogmiosuse the new indirection layer
090d110 to
a28a858
Compare
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
a28a858 to
68bc427
Compare
This PR include:
cardano.providers.node(and switchourainto it to test)TODO: