Skip to content

Conversation

@avnik
Copy link
Contributor

@avnik avnik commented Dec 30, 2023

Closing #19
Closing #20
Also contain fix a CI check for licenses, and some cleanup

@avnik avnik requested a review from aciceri December 30, 2023 16:03
Copy link
Member

@aciceri aciceri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What browser do you use?
The problem is reduced now but still appreciable.

image

(Tested both Firefox and Google Chrome)

Edit: nevermind, I haven't noticed that now there is a mini horizontal scrollbar at the bottom.

I'm thinking if I really like it or the text should break into multiple lines instead.

Edit edit:
image
This is what happens with this extra.css:

nav.md-nav--secondary a.md-nav__link {
  word-break: break-all;
}

Still don't know what I prefer. Meanwhile we can merge it as you prefer.

@aciceri
Copy link
Member

aciceri commented Dec 30, 2023

Also if it's easy I would increase the width of the right bar a bit (remember to check that the website is still responsive and works on mobile).

@aciceri aciceri force-pushed the avnik/docsite-fixes branch 5 times, most recently from 0eae852 to b932594 Compare January 24, 2024 11:22
@aciceri aciceri force-pushed the avnik/docsite-fixes branch from b932594 to 104fb76 Compare January 24, 2024 11:26
@aciceri aciceri merged commit 78bed49 into master Jan 24, 2024
@aciceri aciceri deleted the avnik/docsite-fixes branch January 24, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants