add basic cardano-node module #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciceri
force-pushed
the
marton/cardano-node-module
branch
6 times, most recently
from
b70549e to
a33741a
Compare
aciceri
force-pushed
the
marton/cardano-node-module
branch
from
a33741a to
c0d02bc
Compare
brainrake
force-pushed
the
marton/cardano-node-module
branch
12 times, most recently
from
16e8b44 to
2007c6b
Compare
brainrake
force-pushed
the
marton/cardano-node-module
branch
from
2007c6b to
6e3d03a
Compare
Contributor
Author
|
works, with kvm! |
aciceri
reviewed
Mar 14, 2024
| # import all of our flake nixos modules by default | ||
| nixosModules.default | ||
| # fix missing pkgs.system in tests | ||
| {nixpkgs.overlays = [(_: _: {inherit system;})];} |
Member
There was a problem hiding this comment.
Still wondering why in tests there is not pkgs.system...
aciceri
reviewed
Mar 14, 2024
| checks = | ||
| mapAttrs' | ||
| (name: test: nameValuePair "testing-${test.name}" (cfg._mkCheckFromTest test)) | ||
| (name: test: nameValuePair "nixosTests-${test.name}" test.check) |
Member
There was a problem hiding this comment.
In the end you kept a prefix for checks which are tests!
Contributor
Author
There was a problem hiding this comment.
yes but i named it the same as the module :)
aciceri
reviewed
Mar 14, 2024
| enable = true; | ||
| hostAddr = "0.0.0.0"; | ||
|
|
||
| environment = config.cardanoNix.globals.network; |
Member
There was a problem hiding this comment.
So do we want to keep globals as name?
Contributor
Author
There was a problem hiding this comment.
no, in fact, we may want to move the options one level up under cardanoNix
aciceri
reviewed
Mar 14, 2024
| nixosTests.tests.cardano-node = { | ||
| impure = true; | ||
| module = { | ||
| name = "cardano-node-test"; |
Member
There was a problem hiding this comment.
We can drop name here if you want, by the default it would be cardano-node and the corresponding check nixosTests-cardano-node
aciceri
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.