Prototype of tests #9
Conversation
aciceri
left a comment
aciceri
left a comment
There was a problem hiding this comment.
I haven't tried it anyway. Does it already work?
checks/testing.nix
Outdated
| pkgs = import inputs.nixpkgs { | ||
| inherit system; | ||
| overlays = [ | ||
| ]; | ||
| }; |
There was a problem hiding this comment.
You can override _module.args.pkgs. IMO it's a bit cleaner than using let.
checks/testing.nix
Outdated
| checks = mkOption { | ||
| type = types.attrsOf types.package; | ||
| default = {}; | ||
| internal = true; | ||
| }; |
There was a problem hiding this comment.
Do we need this? Can't we directly assigned to flake.checks?
| type = types.lazyAttrsOf (types.submodule { | ||
| options = { | ||
| systems = mkOption { | ||
| type = types.listOf types.str; |
There was a problem hiding this comment.
If you want to create a cleaner type consider using lib.systems.flakeExposed which gives you a list of all systems used in nixpkgs.
lib/default.nix
Outdated
| options.cardanoNix = lib.mkOption { | ||
| type = lib.types.lazyAttrsOf lib.types.submodule; | ||
| }; |
There was a problem hiding this comment.
Is this needed? Can't we simply declare options.cardanoNix.<thing>?
| module = mkOption { | ||
| type = types.defferedModule; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This lacks a name option that by default is equal to config._module.args.name.
|
@avnik is there any reason why it's marked as draft or it's ready? |
No description provided.