Minor improvements to lbf frontend scripts.
#125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #121 , this PR does some minor improvements to the
lbffrontend scripts (I'll call these porcelain in contrast to the low level plumbing -- this is the nomenclature thatgituses which has a similar architecture! Seeman gitcore-tutorial)Replaced
$@with"$@"in thelbfscripts. The reason why this is important is because if there's a single argument with a space in it, the former will make it two arguments instead of a single argument.Moreover, as a minimal example, we can see that
shellcheck(from CI) doesn't like$@either:Given:
test.bashas followsWe can see that
shellcheckgets angryAdded
-ptomkdirPreviously, if we ran any of the
lbfshell scripts twice, we'd get something like:Note the
Not sure if there's a good reason to have this output here, but adding the
-pflag will silence this.