Add listing contract, add test, restructure slightly #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4ccer
reviewed
Sep 6, 2022
| -> Contract r TransactionHash | ||
| marketPlaceSell (curr /\ tn) = do | ||
| owner <- liftedM "Cannot get PaymentPubKeyHash" ownPaymentPubKeyHash | ||
| ownerStake <- liftedM "Cannot get StakePubKeyHash" ownStakePubKeyHash |
Contributor
There was a problem hiding this comment.
Should it throw error when there is no staking key? Maybe constructing an address without staking key would be more desired
Contributor
Author
There was a problem hiding this comment.
Good point, copied this from the minting contract, ill update it
src/Seabug/Contract/Util.purs
Outdated
| ( Datum $ toData $ | ||
| MarketplaceDatum { getMarketplaceDatum: asset } | ||
| ) | ||
| (Value.singleton (fst asset) (snd asset) one) |
Contributor
There was a problem hiding this comment.
How does balancing/min ADA requirement work? Will some balancing mechanism add missing ADA here?
Contributor
Author
There was a problem hiding this comment.
yes, it does, as the plutip tests pass, but I'll add it in explicit regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.