Skip to content

Conversation

@MasterJH5574
Copy link
Member

Reverts #390 due to it introducing breaking changes on parameters and not being mature for merge.

@MasterJH5574
Copy link
Member Author

cc @yzh119 @tqchen @Kathryn-cat

@junrushao
Copy link
Member

Oh looks like a premature merge! Well, the PR is really well implemented and documented, which may cause a misconception that it’s been complete for a while :))

Let’s continue the work in a new PR!

@junrushao junrushao merged commit 2909069 into main Jun 22, 2023
@MasterJH5574 MasterJH5574 deleted the revert-390-pr-minigpt branch July 5, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants