Update tuning rules to exclude test set from scoring procedure #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
priyakasimbeg
previously approved these changes
Nov 3, 2023
fsschneider
dismissed
priyakasimbeg’s stale review
The merge-base changed after approval.
georgedahl
previously approved these changes
Nov 6, 2023
Contributor
georgedahl
left a comment
georgedahl
left a comment
There was a problem hiding this comment.
Some of these things need to change, but maybe we should just merge this PR and do another after it? For example, just merge this and then make it clear the submission process information is just documentation?
fsschneider
dismissed
georgedahl’s stale review
The merge-base changed after approval.
georgedahl
previously approved these changes
Nov 6, 2023
fsschneider
dismissed
georgedahl’s stale review
The merge-base changed after approval.
priyakasimbeg
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the WG meetings, this PR updates the rules to use "Option C", i.e. removing the test set from the scoring procedure and instead only using the validation set.
The test targets are still defined for each workload and will be used for additional analysis of the results but they are not relevant for scoring/ranking submissions.
Merge after #476