Skip to content

Scoring fixes #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 2, 2023
Merged

Scoring fixes #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
515dc09
add loss metric to min_eval_metrics registry
priyakasimbeg Oct 24, 2023
1b8c1dc
debugging
priyakasimbeg Oct 24, 2023
4441f32
add loss to scoring registry
priyakasimbeg Oct 24, 2023
5fd528a
fix index
priyakasimbeg Oct 24, 2023
0146ecb
add map to max eval metrics
priyakasimbeg Oct 24, 2023
a415e57
add blue to max eval metrics
priyakasimbeg Oct 24, 2023
0d836cf
remove print statement
priyakasimbeg Oct 24, 2023
8a4f8fb
debugging
priyakasimbeg Oct 24, 2023
d70f432
df
priyakasimbeg Oct 24, 2023
03ad1df
fix
priyakasimbeg Oct 24, 2023
8a937ee
fix
priyakasimbeg Oct 24, 2023
87e0762
verbosity
priyakasimbeg Oct 24, 2023
6723232
fix
priyakasimbeg Oct 24, 2023
e9d3c7d
debugging print statements
priyakasimbeg Oct 25, 2023
4df526b
remove debugging print statements
priyakasimbeg Oct 30, 2023
1cb02ca
remove tabulate import
priyakasimbeg Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scoring/scoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@
'ctc_loss',
'wer',
'l1_loss',
'loss',
]

MAX_EVAL_METRICS = ['average_precision', 'ssim', 'accuracy', 'bleu_score']
MAX_EVAL_METRICS = ['mean_average_precision', 'ssim', 'accuracy', 'bleu']


def generate_eval_cols(metrics):
Expand Down Expand Up @@ -128,8 +129,7 @@ def get_index_that_reaches_target(workload_df,
op = operator.le if is_minimized else operator.ge
validation_target_reached = validation_series.apply(
lambda x: op(x, validation_target))

target_reached = pd.Series(validation_target_reached[0])
target_reached = pd.Series(validation_target_reached)
# Remove trials that never reach the target
target_reached = target_reached[target_reached.apply(np.any)]

Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ install_requires =
absl-py==1.4.0
numpy>=1.23
pandas>=2.0.1
tabulate==0.9.0
Copy link
Contributor

@runame runame Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used anywhere else in the repo? Couldn't find anything with a quick search.

tensorflow==2.12.0
tensorflow-datasets==4.9.2
tensorflow-probability==0.20.0
Expand Down