Skip to content

Add score table to scoring script with raw scores #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 10, 2023
Merged

Add score table to scoring script with raw scores #565

merged 8 commits into from
Nov 10, 2023

Conversation

@priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Nov 8, 2023 •
edited
Loading

Addresses #557

  • Refactor package and module names to prevent import errors.
  • Add script to output raw scores per workload per trial.
  • Clean up of utility methods.
  • Moved some warnings from low level utility functions to higher level scoring functions, because with these new features the warnings are only relevant for final performance profile scores.

@github-actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title Add scoring script for raw scores Add score table to scoring script with raw scores Nov 8, 2023
@priyakasimbeg priyakasimbeg requested a review from runame November 8, 2023 01:53
runame
runame reviewed Nov 8, 2023
View reviewed changes
@priyakasimbeg priyakasimbeg requested a review from runame November 8, 2023 20:03
@priyakasimbeg priyakasimbeg marked this pull request as ready for review November 8, 2023 21:02
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner November 8, 2023 21:02
runame
runame previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my minor comments, LGTM.

@priyakasimbeg priyakasimbeg requested a review from runame November 9, 2023 21:07
runame
runame approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@priyakasimbeg priyakasimbeg merged commit fd090dc into dev Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@priyakasimbeg priyakasimbeg deleted the raw_scores branch November 28, 2023 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@runame runame runame approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@priyakasimbeg @runame