Skip to content

Fix installing decimal extension #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Fix installing decimal extension #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions PhpManager/public/Install-PhpExtension.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@
$additionalFiles += $libcouchbaseDll
}
}
'decimal' {
$libmpdecDll = Join-Path -Path $tempFolder -ChildPath 'libmpdec.dll'
if (Test-Path -LiteralPath $libmpdecDll -PathType Leaf) {
$additionalFiles += $libmpdecDll
}
}
'imagick' {
$additionalFiles += @(Get-ChildItem -Path $tempFolder\CORE_*.dll -File -Depth 1)
$additionalFiles += @(Get-ChildItem -Path $tempFolder\IM_*.dll -File -Depth 1)
Expand Down
9 changes: 9 additions & 0 deletions test/tests/Install-Enable-Extensions.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,15 @@
$couchbase.Type | Should -BeExactly 'Php'
$couchbase.State | Should -BeExactly 'Enabled'
}
It -Name 'should download and install decimal on PHP <version>' -TestCases $testCases {
param ($path, $version)
Get-PhpExtension -Path $path | Where-Object { $_.Handle -eq 'decimal' } | Should -HaveCount 0
Install-PhpExtension -Extension decimal -Path $path
$decimal = Get-PhpExtension -Path $path | Where-Object { $_.Handle -eq 'decimal' }
$decimal | Should -HaveCount 1
$decimal.Type | Should -BeExactly 'Php'
$decimal.State | Should -BeExactly 'Enabled'
}
It -Name 'should handle multiple extension versions' {
$phpPath = Join-Path -Path $Global:PHPMANAGER_TESTINSTALLS -ChildPath (New-Guid).Guid
Install-Php -Version 7.1 -Architecture x64 -ThreadSafe $true -Path $phpPath
Expand Down