Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"astro": "astro"
},
"dependencies": {
"astro": "^5.13.2"
"astro": "^5.13.3"
},
"devDependencies": {
"prettier": "^3.6.2",
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
onlyBuiltDependencies:
- esbuild
- sharp
Comment on lines +1 to +3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The onlyBuiltDependencies key is not a valid configuration for pnpm-workspace.yaml. This file is intended for defining workspace packages. If your goal is to specify which dependencies should be built from source, this configuration should be placed in an .npmrc file at the root of your project.

To fix this, you should delete this file and create a .npmrc file with the following content:

only-built-dependencies=esbuild,sharp

This misconfiguration is critical because it will be silently ignored, and the intended build behavior will not be applied.

32 changes: 16 additions & 16 deletions src/components/Footer.astro
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
---
import '../styles/global.css';
import Social from './Social.astro';

---

<style>
footer {
display: flex;
gap: 1rem;
margin-top: 2rem;
}
</style>

<footer>
<Social platform="github" username="mmert9008" />
---
import '../styles/global.css';
import Social from './Social.astro';
---
<style>
footer {
display: flex;
gap: 1rem;
margin-top: 2rem;
}
</style>
<footer>
<Social platform="github" username="mmert9008" />
</footer>
Comment on lines +15 to 17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a common convention to end files with a newline character. This helps prevent issues with version control systems and various command-line tools. Please add a newline at the end of this file.

<footer>
  <Social platform="github" username="mmert9008" />
</footer>

18 changes: 9 additions & 9 deletions src/components/Navigation.astro
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
import '../styles/global.css';
---

<a href="/">Home</a>
<a href="/about/">About</a>
<a href="/blog/">Blog</a>
---
import '../styles/global.css';
---

<a href="/">Home</a>
<a href="/about/">About</a>
<a href="/blog/">Blog</a>
30 changes: 15 additions & 15 deletions src/components/Social.astro
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
---
import '../styles/global.css';
const { platform, username } = Astro.props;
---

<a href={`https://www.${platform}.com/${username}`}>{platform}</a>

<style>
a {
padding: 0.5rem 1rem;
color: white;
background-color: #4c1d95;
text-decoration: none;
}
---
import '../styles/global.css';
const { platform, username } = Astro.props;
---

<a href={`https://www.${platform}.com/${username}`}>{platform}</a>

<style>
a {
padding: 0.5rem 1rem;
color: white;
background-color: #4c1d95;
text-decoration: none;
}
</style>
Comment on lines +9 to 16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please add a newline at the end of the file. It's a standard convention that improves compatibility with various development tools and ensures consistency across the project.

<style>
  a {
    padding: 0.5rem 1rem;
    color: white;
    background-color: #4c1d95;
    text-decoration: none;
  }
</style>

20 changes: 10 additions & 10 deletions src/pages/posts/post-2.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: My Second Blog Post
author: Astro Learner
description: "After learning some Astro, I couldn't stop!"
image:
url: "https://docs.astro.build/assets/arc.webp"
alt: "The Astro logo on a dark background with a purple gradient arc."
pubDate: 2025-08-19
tags: ["astro", "blogging", "learning in public", "successes"]
---
---
title: My Second Blog Post
author: Astro Learner
description: "After learning some Astro, I couldn't stop!"
image:
url: "https://docs.astro.build/assets/arc.webp"
alt: "The Astro logo on a dark background with a purple gradient arc."
pubDate: 2025-08-19
tags: ["astro", "blogging", "learning in public", "successes"]
---
After a successful first week learning Astro, I decided to try some more. I wrote and imported a small component from memory!
Comment on lines +10 to 11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a good practice to end all text files with a newline character. Please add one to this file for consistency and to adhere to POSIX standards.

Suggested change
---
After a successful first week learning Astro, I decided to try some more. I wrote and imported a small component from memory!
---
After a successful first week learning Astro, I decided to try some more. I wrote and imported a small component from memory!

20 changes: 10 additions & 10 deletions src/pages/posts/post-3.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: My Third Blog Post
author: Astro Learner
description: "I had some challenges, but asking in the community really helped!"
image:
url: "https://docs.astro.build/assets/rays.webp"
alt: "The Astro logo on a dark background with rainbow rays."
pubDate: 2025-08-19
tags: ["astro", "learning in public", "setbacks", "community"]
---
---
title: My Third Blog Post
author: Astro Learner
description: "I had some challenges, but asking in the community really helped!"
image:
url: "https://docs.astro.build/assets/rays.webp"
alt: "The Astro logo on a dark background with rainbow rays."
pubDate: 2025-08-19
tags: ["astro", "learning in public", "setbacks", "community"]
---
It wasn't always smooth sailing, but I'm enjoying building with Astro. And, the [Discord community](https://astro.build/chat) is really friendly and helpful!
Comment on lines +10 to 11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please add a final newline to this file. This is a standard convention for text files and improves compatibility with many development tools.

Suggested change
---
It wasn't always smooth sailing, but I'm enjoying building with Astro. And, the [Discord community](https://astro.build/chat) is really friendly and helpful!
---
It wasn't always smooth sailing, but I'm enjoying building with Astro. And, the [Discord community](https://astro.build/chat) is really friendly and helpful!

60 changes: 30 additions & 30 deletions src/styles/global.css
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
*,
::before,
::after,
::backdrop,
::file-selector-button {
box-sizing: border-box;
margin: 0;
padding: 0;
}

html {
background-color: #f1f5f9;
font-family: sans-serif;
}

body {
margin: 0 auto;
width: 100%;
max-width: 80ch;
padding: 1rem;
line-height: 1.5;
}

* {
box-sizing: border-box;
}

h1 {
margin: 1rem 0;
font-size: 2.5rem;
*,
::before,
::after,
::backdrop,
::file-selector-button {
box-sizing: border-box;
margin: 0;
padding: 0;
}
html {
background-color: #f1f5f9;
font-family: sans-serif;
}
body {
margin: 0 auto;
width: 100%;
max-width: 80ch;
padding: 1rem;
line-height: 1.5;
}
* {
box-sizing: border-box;
}
Comment on lines +24 to +26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This box-sizing rule is redundant because the universal selector * is already covered by the rule on lines 1-9, which also sets box-sizing: border-box;. Removing this duplication will make the stylesheet cleaner and easier to maintain.

h1 {
margin: 1rem 0;
font-size: 2.5rem;
}
Comment on lines +28 to 31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a standard convention to end files with a newline character. This prevents potential issues with some tools and version control systems. Please add a newline here.

Suggested change
h1 {
margin: 1rem 0;
font-size: 2.5rem;
}
h1 {
margin: 1rem 0;
font-size: 2.5rem;
}