Skip to content

Enable compressed pointers for Compressor #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

Enable compressed pointers for Compressor #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f357b
Enable compressed pointers for Compressor
k-sareen Aug 29, 2025
50a16e9
Point MMTk to Compressor PR
k-sareen Aug 29, 2025
15dacdd
Update mmtk-core
qinsoon Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/configs/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ configs:
- "jdk11-master|ms|s|fail_on_oom|tph|preserve|mmtk_gc-StickyImmix"
- "jdk11-master|ms|s|fail_on_oom|tph|preserve|mmtk_gc-MarkSweep"
- "jdk11-master|ms|s|fail_on_oom|tph|preserve|mmtk_gc-MarkCompact"
# TODO: We need to disable compressed oops for Compressor temporarily until it supports
# discontiguous spaces.
- "jdk11-master|ms|s|fail_on_oom|tph|preserve|no_compressed_oops|mmtk_gc-Compressor"
- "jdk11-master|ms|s|fail_on_oom|tph|preserve|mmtk_gc-Compressor"

benchmarks:
dacapo-23.9-RC3-chopin-ci:
4 changes: 1 addition & 3 deletions .github/scripts/ci-test-minimal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ MMTK_PLAN=GenImmix runbms_dacapo2006_with_heap_multiplier fop 4
MMTK_PLAN=StickyImmix runbms_dacapo2006_with_heap_multiplier fop 4
MMTK_PLAN=GenCopy runbms_dacapo2006_with_heap_multiplier fop 4
MMTK_PLAN=MarkCompact runbms_dacapo2006_with_heap_multiplier fop 4
# TODO: Need to temporarily disable compressed oops for the Compressor until it supports
# discontiguous spaces.
MMTK_PLAN=Compressor runbms_dacapo2006_with_heap_multiplier fop 4 -XX:-UseCompressedOops -XX:-UseCompressedClassPointers
MMTK_PLAN=Compressor runbms_dacapo2006_with_heap_multiplier fop 4
MMTK_PLAN=MarkSweep runbms_dacapo2006_with_heap_multiplier fop 8
MMTK_PLAN=NoGC runbms_dacapo2006_with_heap_size fop 1000 1000
# Test heap resizing
Expand Down
4 changes: 1 addition & 3 deletions .github/scripts/ci-test-vo-bit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ run_subset 8
# --- Compressor ---
export MMTK_PLAN=Compressor

# TODO: Need to temporarily disable compressed oops for the Compressor until it
# supports discontiguous spaces.
run_subset 4 "-XX:-UseCompressedOops -XX:-UseCompressedClassPointers"
run_subset 4

# --- NoGC ---

Expand Down
5 changes: 3 additions & 2 deletions mmtk/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mmtk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ probe = "0.5"
# - change branch
# - change repo name
# But other changes including adding/removing whitespaces in commented lines may break the CI.
mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "7d798ad8a71aa6df80f58f5e565e4f9274d06871" }
mmtk = { git = "https://github.com/mmtk/mmtk-core.git", rev = "a061e0519bee0b7fb3b8d768f37885537654486e" }
# Uncomment the following to build locally
# mmtk = { path = "../repos/mmtk-core" }

Expand Down
Loading