Conversation
mnahkies
added a commit
that referenced
this pull request
Mar 2, 2024
Adopt "strictest" typescript base settings, and adjust code generation
to support this
- Fix various typescript errors that popped up
- Avoiding passing `timeout` key when no timeout passed for axios to be
compatible with `exactOptionalPropertyTypes`
- Attempt to read and parse the `tsconfig.json` for specified output
directory
- For `typescript-koa` include `| undefined` on optional properties when
`exactOptionalPropertyTypes` is configured
- This shouldn't be required for the clients, as in this case the
consumer can choose to omit keys
- Though maybe it's more ergonomic to follow this behavior anyway?
- Not dealt with stripping unused imports so far
- It should be _relatively_ easy to adjust the way imports are handled
in the type / schema builders to not import things that aren't used in
the main file
- But it's possible that with #129 and
https://biomejs.dev/linter/rules/no-unused-imports/#_top we could just
plug our fingers in our ears and let the linter figure it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the use of
prettierwith https://biomejs.dev/ for code formatting.This speeds up the formatting of the integration tests significantly, reducing the formatting execution time in CI from ~40% of total to ~10-20% with minimal change in output.
Will likely follow up by replacing
eslintas well.