-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Milestone
Description
I've stumbled on a not-so-nice aspect of the API when working on #7486:
mne.io.pick.get_channel_types(source) takes no input, gets all known channel types as dict keys (values are FIFF constants forkindandcoil_type).mne.io.pick._get_channel_types(source) takes anInfo, picks, booleanunique, and boolean whether to restrict to data channels only. Returns a list or set depending onunique.<Raw/Epochs/Evoked>.get_channel_types(source) method (via theContainsMixin). Returns list of channel types.
Number 1 is called once in a test, and nowhere else in the codebase. I'd like to propose renaming it from get_channel_types to get_all_channel_types, show_all_channel_types, or get_channel_types_dict. I prefer the first option. This is a public function so it would be an API change w/ deprecation cycle. If acceptable, I could roll it into #7486 or do it in a separate PR.
Metadata
Metadata
Assignees
Labels
No labels