Skip to content

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Jan 24, 2022

Somehow Qt applies a weird color scheme to the status bar on macOS and the text color is white by default, which makes it barely readable. This PR changes the text color to black.

main PR
Screen Shot 2022-01-24 at 09 44 53 Screen Shot 2022-01-24 at 09 44 34

cc @GuillaumeFavelier @agramfort

Somehow Qt applies a weird color scheme to the status bar on macOS and
the text color is white by default, which makes it barely readable.
This commit changes the text color to black.
@hoechenberger hoechenberger marked this pull request as ready for review January 24, 2022 08:46
@hoechenberger hoechenberger changed the title Change CoregistrationUI status bar text color to black MRG: Change CoregistrationUI status bar text color to black Jan 24, 2022
@GuillaumeFavelier
Copy link
Contributor

I tested those changes locally and it actually affects qdarkstyle's dark theme, I think it decreases the contrast for me (look at the color of Press ? for help in the status bar):

main PR
image image
import os
import mne
from mne.datasets import sample


data_path = sample.data_path()
sample_dir = os.path.join(data_path, 'MEG', 'sample')
subjects_dir = os.path.join(data_path, 'subjects')
fname_stc = os.path.join(sample_dir, 'sample_audvis-meg')
stc = mne.read_source_estimate(fname_stc, subject='sample')
initial_time = 0.096
mne.viz.set_3d_backend('pyvista')

brain = stc.plot(subjects_dir=subjects_dir, initial_time=initial_time,
                 clim=dict(kind='value', lims=[3, 6, 9]),
                 size=600,
                 hemi='rh',
                 views=['lat', 'med'],
                 brain_kwargs=dict(block=True, theme='dark'),
                 )

Let's work on it together to find a solution that can work for everyone @hoechenberger

@hoechenberger
Copy link
Member Author

Yes let's try to find a solution that doesn't override the qdarkstyle stylesheets

@hoechenberger hoechenberger changed the title MRG: Change CoregistrationUI status bar text color to black Change CoregistrationUI status bar text color to black Jan 24, 2022
@hoechenberger hoechenberger marked this pull request as draft January 24, 2022 12:07
@GuillaumeFavelier
Copy link
Contributor

This issue might be fixed by #10456?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants