MRG: Expose drop log #4652
Merged
MRG: Expose drop log #4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
- Coverage 87.69% 87.68% -0.02%
==========================================
Files 351 351
Lines 66593 66613 +20
Branches 10347 11550 +1203
==========================================
+ Hits 58401 58408 +7
- Misses 5235 5253 +18
+ Partials 2957 2952 -5 |
Member
|
don't forget the versionadded + what's new udpate |
Member
Author
|
Yes I'm planning on this being 0.16, waiting for release |
Member
Author
|
Okay I added 0.15 because we're in a holding pattern anyway |
Member
|
thx @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting
Noneas proj because all epochs are rejected, it's nice to have the option to see why (and pass the result toplot_drop_log).