error: implicit conversion changes signedness: 'enum vm_reg_name' to 'int'

[jrjsmrtn]

I got this when compiling revision 64bbfbe on Mojave:

$ make
gen src/lib/dtrace.d
cc src/lib/vmm/intel/vmcs.c
cc src/lib/vmm/intel/vmx.c
src/lib/vmm/intel/vmx.c:1368:34: error: implicit conversion changes signedness: 'enum vm_reg_name' to 'int' [-Werror,-Wsign-conversion]
        error = vmx_getreg(vmx, vcpuid, reg, &val);
                ~~~~~~~~~~              ^~~
src/lib/vmm/intel/vmx.c:1419:40: error: implicit conversion changes signedness: 'enum vm_reg_name' to 'int' [-Werror,-Wsign-conversion]
        error = vmx_getdesc(vmx, vcpuid, vis->seg_name, &vis->seg_desc);
                ~~~~~~~~~~~              ~~~~~^~~~~~~~
2 errors generated.
make: *** [build/lib/vmm/intel/vmx.o] Error 1

My environment is:

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.14.3
BuildVersion:	18D109

$ xcodebuild -version
Xcode 10.1
Build version 10B61

$ cc --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

HTH

[ijc]

Thanks @jrjsmrtn for your report. Based on a quick look I would guess that vmx_getreg and vmx_setreg should both take an enum vm_reg_name reg instead of an int reg (which might then involve casting the enum away inside those functions, the compiler will tell you if that is the case I expect).

Do you feel up to raising a PR?

[jrjsmrtn]

Hello, Ian. | Do you feel up to raising a PR? Unfortunately, I am not a C guy, so it’s better I do not :-) That said, I’m working on MacPorts packages for xhyve/hyperkit/tianocore, so I’ll gladly test new releases and submit reports. G.

…

Le 20 févr. 2019 à 11:33, Ian Campbell ***@***.***> a écrit : Thanks @jrjsmrtn for your report. Based on a quick look I would guess that vmx_getreg and vmx_setreg should both take an enum vm_reg_name reg instead of an int reg (which might then involve casting the enum away inside those functions, the compiler will tell you if that is the case I expect). Do you feel up to raising a PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Bauer312]

I am using 64bbfbe and see the same error but in a different file:

cc src/lib/firmware/bootrom.c
cc src/lib/firmware/kexec.c
cc src/lib/firmware/fbsd.c
src/lib/firmware/fbsd.c:690:7: error: implicit conversion changes signedness: 'unsigned int' to 'int' [-Werror,-Wsign-conversion]
        case MSR_EFER:
             ^~~~~~~~
In file included from src/lib/firmware/fbsd.c:80:
src/include/xhyve/support/specialreg.h:771:18: note: expanded from macro 'MSR_EFER'
#define MSR_EFER        0xc0000080      /* extended features */
                        ^~~~~~~~~~
1 error generated.
make: *** [build/lib/firmware/fbsd.o] Error 1

My environment is

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.14.4
BuildVersion:	18E226

$ xcodebuild -version
Xcode 10.2
Build version 10E125

$ cc --version
Apple LLVM version 10.0.1 (clang-1001.0.46.3)
Target: x86_64-apple-darwin18.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

This was fixed upstream in xhyve: machyve/xhyve@9ea6650

I'm happy to create a PR and fix if that is the preferred method :)

[ijc]

Thanks @Bauer312 a PR would be most welcome.

[ijc]

#248 is merged, closing. Thanks!

[jrjsmrtn]

Sorry to bother you but the issue in vmx.c is not resolved in revision e499d90 :-/

$ make
cc src/lib/vmm/intel/vmx.c
src/lib/vmm/intel/vmx.c:1368:34: error: implicit conversion changes signedness: 'enum vm_reg_name' to 'int' [-Werror,-Wsign-conversion]
        error = vmx_getreg(vmx, vcpuid, reg, &val);
                ~~~~~~~~~~              ^~~
src/lib/vmm/intel/vmx.c:1419:40: error: implicit conversion changes signedness: 'enum vm_reg_name' to 'int' [-Werror,-Wsign-conversion]
        error = vmx_getdesc(vmx, vcpuid, vis->seg_name, &vis->seg_desc);
                ~~~~~~~~~~~              ~~~~~^~~~~~~~
2 errors generated.
make: *** [build/lib/vmm/intel/vmx.o] Error 1

My environment is now:

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.14.5
BuildVersion:	18F132

$ xcodebuild -version
Xcode 10.2.1
Build version 10E1001

$ cc --version
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[Bauer312]

Hi @jrjsmrtn I am not seeing this error on my Mac with 10.14.4, though I have the same Xcode and Clang as you. I'll update to 10.14.5 shortly and test again.

[rajivmucheli]

Hi @Bauer312,

I have the same config as @jrjsmrtn and get the same error, is this fixed ?