Fix for multiboot loader #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperkit's multiboot loader incorrectly loads the firmware into guest memory.
This patch fixes the offset used to load the firmware image by using the offset of the first (smallest offset) loaded program segment in an elf32 firmware.
In essence what was happening before this patch was that hyperkit would load the entire ELF32 binary into memory from the start of the image. In some cases this works due to how some firmware image are built, but the correct behavior I think should be to find the offset instead of having to apply some link time tricks.