build: Add entitlements #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Bigsur need to add Hypervisor framework entitlement. Based on https://stackoverflow.com/questions/64642062/apple-hypervisor-is-completely-broken-on-macos-big-sur-beta-11-0-1 via moby#300 (comment) Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
djs55
approved these changes
Dec 18, 2020
Collaborator
djs55
left a comment
djs55
left a comment
There was a problem hiding this comment.
Makes sense.
I checked and in Docker Desktop we also sign with this entitlement when we build hyperkit.
I wonder whether there's any limitation on binary distribution. Is any developer allowed to sign binaries with this entitlement and then ship them? Doesn't matter here, but I'm curious.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Bigsur need to add Hypervisor framework entitlement.
Based on https://stackoverflow.com/questions/64642062/apple-hypervisor-is-completely-broken-on-macos-big-sur-beta-11-0-1
via #300 (comment)
Signed-off-by: Rolf Neugebauer rn@rneugeba.io
fixes #300