Remove btrfs quota groups after containers destroyed #29427

yongtang · 2016-12-14T22:03:53Z

- What I did

This fix tries to address the issue raised in #29325 where btrfs quota groups are not clean up even after containers have been destroyed.

- How I did it

The reason for the issue is that btrfs quota groups have to be explicitly destroyed. This fix fixes this issue.

- How to verify it

This fix is tested manually in Ubuntu 16.04:

pre-fix behavior with qgroup leftover:

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
b59e6e3da6ed3e601f081c11c44d3f4dd44aefee5584d34ba913e68207c9694d
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         144.00KiB    144.00KiB
0/257         1.17MiB      1.17MiB
0/258           0.00B        0.00B
0/259           0.00B        0.00B

PR with qgroup cleaned (non --live-restore case):

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
201d444f74943247c7794fae2215f763cad0dd726d03285004c54ffa04882d6b
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         144.00KiB    144.00KiB
0/257         1.17MiB      1.17MiB

PR with qgroup cleaned (--live-restore case):

# [sudo dockerd --debug --live-restore -s btrfs --storage-opt btrfs.min_space=1G]

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
73c2184a4414d47b5f5dc27cd2ee28116aa761f947196618ca66bf05c4705456
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$

# [Ctrl-C ]
# [sudo dockerd --debug --live-restore -s btrfs]

ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED              STATUS              PORTS               NAMES
73c2184a4414        busybox             "top"               About a minute ago   Up About a minute                       top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         152.00KiB    152.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     48.00KiB
0/259         1.17MiB     48.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         168.00KiB    168.00KiB
0/257         1.17MiB     64.00KiB

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This fix fixes #29325.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

yongtang · 2016-12-19T16:18:06Z

/cc @justincormack @mlaventure

zhuguihua · 2016-12-28T09:55:35Z

Sorry for late reply. LGTM.

yongtang · 2017-01-03T01:52:08Z

Previously the PR didn't take into consideration that, if quotaEnabled is false, there is no need to clean up the qgroup (See #29810 for similar issue)

Now the PR has been updated to add the check for quotaEnabled.

thaJeztah · 2017-01-03T12:41:25Z

Also wondering the same here as on #29835 (comment)

mlaventure · 2017-01-03T20:53:09Z

I had a quick look at the code, it looks like @thaJeztah may be correct.

Would wait on @cpuguy83 for confirmation

thaJeztah · 2017-01-03T20:57:33Z

if I'm correct, we may need some mechanism to detect if a quota is set (perhaps querying btrfs), otherwise it's possible we don't know when to cleanup / manage quotas

cpuguy83 · 2017-01-03T21:19:26Z

I think you are right. On daemon restore it could really be a problem.

LK4D4 · 2017-01-26T18:50:12Z

@cpuguy83 @tonistiigi @yongtang so, what we're going to do with this and #29385
If we have no proper solution for now, I propose to close PRs.
Thanks!

yongtang · 2017-01-26T19:35:13Z

@cpuguy83 @tonistiigi @LK4D4 This PR (#29427) and the other PR (#29835) are related.

I updated the other PR #29835 first to try to address the issue by looking up the qgroup and see if it returns something.

Please take a look at the (#29835) first and see if it address the concerns.

yongtang · 2017-01-28T18:01:00Z

Here is the complete steps to verify that the issue is fixed (Including --live-restore case).

Would be good to setup integration test for btrfs in Jenkins

Note: this PR has been updated to incorporate #30497. If this one is merged then #30497 could be closed

pre-fix behavior with qgroup leftover:

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
b59e6e3da6ed3e601f081c11c44d3f4dd44aefee5584d34ba913e68207c9694d
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         144.00KiB    144.00KiB
0/257         1.17MiB      1.17MiB
0/258           0.00B        0.00B
0/259           0.00B        0.00B

PR with qgroup cleaned (non --live-restore case):

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
201d444f74943247c7794fae2215f763cad0dd726d03285004c54ffa04882d6b
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         144.00KiB    144.00KiB
0/257         1.17MiB      1.17MiB

PR with qgroup cleaned (--live-restore case):

# [sudo dockerd --debug --live-restore -s btrfs --storage-opt btrfs.min_space=1G]

ubuntu@ubuntu:~$ docker pull busybox
Using default tag: latest
latest: Pulling from library/busybox
4b0bc1c4050b: Pull complete
Digest: sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
Status: Downloaded newer image for busybox:latest
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257       112.00KiB    112.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker run --name top -d busybox top
73c2184a4414d47b5f5dc27cd2ee28116aa761f947196618ca66bf05c4705456
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         128.00KiB    128.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     16.00KiB
0/259         1.17MiB     16.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$

# [Ctrl-C ]
# [sudo dockerd --debug --live-restore -s btrfs]

ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED              STATUS              PORTS               NAMES
73c2184a4414        busybox             "top"               About a minute ago   Up About a minute                       top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         152.00KiB    152.00KiB
0/257         1.17MiB     64.00KiB
0/258         1.17MiB     48.00KiB
0/259         1.17MiB     48.00KiB
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker rm -f top
top
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$
ubuntu@ubuntu:~$ sudo btrfs qgroup show /var/lib/docker/btrfs
qgroupid         rfer         excl
--------         ----         ----
0/5         168.00KiB    168.00KiB
0/257         1.17MiB     64.00KiB

mlaventure · 2017-02-10T16:58:48Z

daemon/graphdriver/btrfs/btrfs.go

@@ -320,7 +337,7 @@ func (d *Driver) subvolEnableQuota() error {
 func (d *Driver) subvolDisableQuota() error {
 	if !d.quotaEnabled {


Shouldn't this be turned into a isQuotaEnabled() routine to avoid this code to be duplicated?

Also, quotaEnabled is just a boolean, but don't we need a lock around it?

mlaventure · 2017-02-10T16:58:56Z

ping @cpuguy83 @tonistiigi

yongtang · 2017-02-13T18:44:35Z

Thanks @mlaventure for the review. The PR has been updated with isQuotaEnabled() and lock added. Please take a look and let me know if there are any issues.

mlaventure · 2017-02-13T19:11:03Z

daemon/graphdriver/btrfs/btrfs.go

+}
+
+func (d *Driver) subvolEnableQuota() error {
+	d.mu.Lock()


move the lock in isQuotaEnabled?

Thanks @mlaventure.

Inside the subvolEnableQuota the d.quotaEnabled will be changed again to true at the end of subvolEnableQuota (located in Line 343). For that I placed the Lock() outside of isQuotaEnabled().

Oh, my bad. Thanks for clarifying.

mlaventure · 2017-03-03T19:17:38Z

ping @cpuguy83 @tonistiigi this is waiting for reviews 👼

thaJeztah · 2017-03-15T12:35:30Z

ping @cpuguy83 @tonistiigi PTAL

cpuguy83 · 2017-04-05T20:35:49Z

This is not re-applying qutoas on daemon restart.

$ docker run -d --name test --storage-opt size=100m busybox top
$ docker exec test sh -c 'dd if=/dev/urandom of=/data bs=1 count=200' # errors around 100M
$ # restart docker
$ # note that `btrfs qgroup show` does not find the qgroup
$ docker start test
$ # note still no qgroup
$ docker exec test sh -c 'dd if=/dev/urandom of=/data bs=1 count=200'  # write successful, no qutoa

cpuguy83 · 2017-04-05T20:45:17Z

It looks like we need to rescan for quota in Get()... or not disable quota on Cleanup()

cpuguy83 · 2017-04-05T20:46:00Z

Or I guess write out a file to trigger an auto-enable of the quota on restart.

mlaventure · 2017-04-25T18:31:37Z

ping @yongtang 👼

thaJeztah · 2017-05-12T09:33:12Z

ping @yongtang do you still have time to work on this?

yongtang · 2017-05-13T05:41:38Z

@thaJeztah Sorry for the late response. Let me spend the next several days to get this one fixed.

yongtang · 2017-05-25T03:47:05Z

@cpuguy83 The PR has been updated. Now the quota is saved in /lib/var/docker/btrfs/quotas and recovered in case of a daemon restart. Not sure this is the best place to persist so any suggestions would be greatly appreciated. Please take a look.

thaJeztah · 2017-05-30T11:06:18Z

ping @cpuguy83

also @cyphar, who may be interested in this 😃

sargun · 2017-05-30T22:02:43Z

Alternatively, you can just wait for this patchset to land: http://www.spinics.net/lists/linux-btrfs/msg65928.html

thaJeztah · 2017-05-31T00:30:38Z

@sargun nice! Unfortunately we don't control the host, so cannot guarantee that patch is present on each distro / version, so not sure we can rely on that

cpuguy83 · 2017-05-31T14:57:02Z

daemon/graphdriver/btrfs/btrfs.go

+	if quota, err := ioutil.ReadFile(d.quotasDirID(id)); err == nil {
+		if size, err := strconv.ParseUint(string(quota), 10, 64); err == nil && size >= d.options.minSpace {
+			d.subvolEnableQuota()
+			subvolLimitQgroup(dir, size)


error check?

cpuguy83 · 2017-05-31T14:57:15Z

daemon/graphdriver/btrfs/btrfs.go

@@ -557,6 +635,13 @@ func (d *Driver) Get(id, mountLabel string) (string, error) {
 		return "", fmt.Errorf("%s: not a directory", dir)
 	}

+	if quota, err := ioutil.ReadFile(d.quotasDirID(id)); err == nil {
+		if size, err := strconv.ParseUint(string(quota), 10, 64); err == nil && size >= d.options.minSpace {
+			d.subvolEnableQuota()


error check?

cpuguy83 · 2017-05-31T14:57:48Z

daemon/graphdriver/btrfs/btrfs.go

@@ -533,7 +606,12 @@ func (d *Driver) Remove(id string) error {
 	if _, err := os.Stat(dir); err != nil {
 		return err
 	}
-	if err := subvolDelete(d.subvolumesDir(), id); err != nil {
+	os.Remove(d.quotasDirID(id))


error check?

Thanks @cpuguy83. Done.

cpuguy83 · 2017-05-31T14:58:28Z

daemon/graphdriver/btrfs/btrfs.go

+		if err := idtools.MkdirAllAs(quotas, 0700, rootUID, rootGID); err != nil {
+			return err
+		}
+		if err := ioutil.WriteFile(path.Join(quotas, id), []byte(fmt.Sprint(driver.options.size)), 0666); err != nil {


Thanks @cpuguy83. The PR has been updated.

This fix tries to address the issue raised in 29325 where btrfs quota groups are not clean up even after containers have been destroyed. The reason for the issue is that btrfs quota groups have to be explicitly destroyed. This fix fixes this issue. This fix is tested manually in Ubuntu 16.04, with steps specified in 29325. This fix fixes 29325. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

This commit is an extension of fix for 29325 based on the review comment. In this commit, the quota size for btrfs is kept in `/var/lib/docker/btrfs/quotas` so that a daemon restart keeps quota. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

yongtang · 2017-06-02T04:17:27Z

Thanks @cpuguy83 for the review. The PR has been updated. Please take a look.

cpuguy83

LGTM

yongtang · 2017-06-06T19:50:45Z

All tests passed now, merging...

GordonTheTurtle added the status/0-triage label Dec 14, 2016

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch 2 times, most recently from 421140b to 57c74de Compare December 15, 2016 16:45

yongtang mentioned this pull request Dec 19, 2016

Docker does not remove Btrfs quota groups when destroying container #29325

Closed

vdemeester added area/storage/btrfs status/2-code-review and removed status/0-triage labels Dec 27, 2016

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch from 57c74de to 44dee9c Compare January 3, 2017 01:47

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch from 44dee9c to ba10de8 Compare January 27, 2017 07:39

GordonTheTurtle assigned mlaventure Feb 10, 2017

yongtang mentioned this pull request Feb 10, 2017

Fix issue of incorrect qgroup detection in #29835 #30497

Closed

mlaventure reviewed Feb 10, 2017

View reviewed changes

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch 2 times, most recently from d7f3c09 to 4d312d6 Compare February 13, 2017 18:41

vdemeester added this to the 1.14.0 milestone Feb 13, 2017

mlaventure reviewed Feb 13, 2017

View reviewed changes

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch from c4604b4 to e09393e Compare April 3, 2017 23:41

yongtang added the rebuild/windowsRS1 label Apr 4, 2017

GordonTheTurtle removed the rebuild/windowsRS1 label Apr 4, 2017

yongtang added the rebuild/windowsRS1 label Apr 4, 2017

GordonTheTurtle removed the rebuild/windowsRS1 label Apr 4, 2017

thaJeztah modified the milestones: 17.06.0, 17.05.0 May 12, 2017

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch 2 times, most recently from 8106d15 to 9792f99 Compare May 25, 2017 01:02

cpuguy83 requested changes May 31, 2017

View reviewed changes

yongtang added 2 commits June 1, 2017 20:24

yongtang force-pushed the 29325-cleanup-btrfs-quota-groups branch from 9792f99 to 16328cc Compare June 2, 2017 04:16

cpuguy83 approved these changes Jun 5, 2017

View reviewed changes

yongtang added the rebuild/z label Jun 6, 2017

GordonTheTurtle removed the rebuild/z label Jun 6, 2017

yongtang merged commit 54dacaf into moby:master Jun 6, 2017

yongtang deleted the 29325-cleanup-btrfs-quota-groups branch June 6, 2017 19:51

		@@ -320,7 +337,7 @@ func (d *Driver) subvolEnableQuota() error {
		func (d *Driver) subvolDisableQuota() error {
		if !d.quotaEnabled {

Remove btrfs quota groups after containers destroyed #29427

Remove btrfs quota groups after containers destroyed #29427

Conversation

yongtang commented Dec 14, 2016 • edited

yongtang commented Dec 19, 2016

zhuguihua commented Dec 28, 2016

yongtang commented Jan 3, 2017

thaJeztah commented Jan 3, 2017

mlaventure commented Jan 3, 2017

thaJeztah commented Jan 3, 2017

cpuguy83 commented Jan 3, 2017

LK4D4 commented Jan 26, 2017

yongtang commented Jan 26, 2017

yongtang commented Jan 28, 2017

Choose a reason for hiding this comment

mlaventure commented Feb 10, 2017

yongtang commented Feb 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlaventure commented Mar 3, 2017

thaJeztah commented Mar 15, 2017

cpuguy83 commented Apr 5, 2017

cpuguy83 commented Apr 5, 2017

cpuguy83 commented Apr 5, 2017

mlaventure commented Apr 25, 2017

thaJeztah commented May 12, 2017

yongtang commented May 13, 2017

yongtang commented May 25, 2017

thaJeztah commented May 30, 2017

sargun commented May 30, 2017

thaJeztah commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yongtang commented Jun 2, 2017

cpuguy83 left a comment

Choose a reason for hiding this comment

yongtang commented Jun 6, 2017

yongtang commented Dec 14, 2016 •

edited