Skip to content

Conversation

jajik
Copy link
Member

@jajik jajik commented Apr 8, 2024

@jajik jajik changed the title Fix mispelled EnableMCMPReceive option Fix misspelled EnableMCMPReceive option Apr 8, 2024
@rhusar rhusar self-assigned this Apr 9, 2024
@jajik
Copy link
Member Author

jajik commented Apr 9, 2024

Just fix for the misspelled misspell 😄

@jajik jajik requested a review from rhusar April 9, 2024 14:38
@jajik
Copy link
Member Author

jajik commented Apr 9, 2024

(I was thinking about adding a note about the misspelled variant, but I don't think it's necessary.)

@rhusar
Copy link
Member

rhusar commented Apr 17, 2024

(I was thinking about adding a note about the misspelled variant, but I don't think it's necessary.)

I am afraid we have to include it.... e.g. for CTRK+F use cases...

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note about the deprecated version with information since which release this is fixed. Perhaps in a NOTE: block

@jajik jajik requested a review from rhusar April 17, 2024 10:46
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@jajik
Copy link
Member Author

jajik commented Apr 17, 2024

@rhusar Note added. I also spotted a typo, so I dared to add a fix here instead of opening a new PR...

@rhusar rhusar merged commit 8bffe65 into modcluster:main Apr 17, 2024
@rhusar
Copy link
Member

rhusar commented Apr 17, 2024

@rhusar Note added. I also spotted a typo, so I dared to add a fix here instead of opening a new PR...

haha, that's totally fine :) thx

@jajik
Copy link
Member Author

jajik commented Apr 17, 2024

Well, that was fast. :D Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants