-
Notifications
You must be signed in to change notification settings - Fork 16
MODCLUSTER-551 Fix spelling of EnableMCPMReceive option #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never noticed this. 😄
Just a nitpick: could you please update the second commit message to something like test: Use proper EnableMCMPReceive option
?
51d0a22
to
a03b492
Compare
Ah, right, we talked about the commit message prefix and forgot to add it myself... Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now.
a03b492
to
1b0d38a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1b0d38a
to
5641a09
Compare
@rhusar We're going to need a rebase here. |
Also, is this something we would like to backport? |
Done, but I am afraid there will be many more rebases :) |
I think we have to - otherwise this will be causing a lot of confusion when applying 'newer' config on legacy versions. But lets get this merged first upstream, that's a de facto requirement. |
Once tests pass, I would be for merging it if @jfclere is not against it.
That's the answer I expected :) it will be easier documentation wise as well |
Merging this one. |
Resolves
https://issues.redhat.com/browse/MODCLUSTER-551